http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
David Cook <dc...@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dc...@prosentient.com.au --- Comment #7 from David Cook <dc...@prosentient.com.au> --- (In reply to comment #6) > Created attachment 14863 [details] [review] > Bug 9394 - Use reserve_id where possible > > This patch switches from using a combination of > biblionumber/borrowernumber to using reserve_id where possible. > > Test Plan: > 1) Apply patch > 2) Run t/db_dependent/Holds.t I tried running the test, but it spat out quite a few errors/fails. I'm not sure if this is a problem with the test or my database though... Here are the test results: t/db_dependent/Holds.t .. 1/18 # Creating biblio instance for testing. # Creating item instance for testing. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`...`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at .../lib//C4/Items.pm line 2105. t/db_dependent/Holds.t .. 2/18 # Failed test 'Test GetReservesFromItemnumber()' # at t/db_dependent/Holds.t line 68. # Failed test 'Test CancelReserve()' # at t/db_dependent/Holds.t line 80. Use of uninitialized value in string eq at t/db_dependent/Holds.t line 92. # Failed test 'Test GetReserve(), priority changed correctly' # at t/db_dependent/Holds.t line 92. # Failed test 'Test GetReserve(), suspend hold' # at t/db_dependent/Holds.t line 93. Use of uninitialized value in string eq at t/db_dependent/Holds.t line 94. # Failed test 'Test GetReserve(), suspend until date' # at t/db_dependent/Holds.t line 94. Use of uninitialized value in string eq at t/db_dependent/Holds.t line 102. # Failed test 'Test ToggleSuspend(), with date' # at t/db_dependent/Holds.t line 102. DBD::mysql::st execute failed: Column 'borrowernumber' cannot be null at .../lib//C4/Reserves.pm line 198. Use of uninitialized value in string eq at t/db_dependent/Holds.t line 126. Use of uninitialized value $itemnumber in string eq at t/db_dependent/Holds.t line 126. Use of uninitialized value in string eq at t/db_dependent/Holds.t line 130. Use of uninitialized value in string eq at t/db_dependent/Holds.t line 130. # Deleting holds. # Deleting item testing instance. DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 at .../lib//C4/Items.pm line 2295. # Deleting biblio testing instance. # Looks like you failed 6 tests of 18. t/db_dependent/Holds.t .. Dubious, test returned 6 (wstat 1536, 0x600) Failed 6/18 subtests Test Summary Report ------------------- t/db_dependent/Holds.t (Wstat: 1536 Tests: 18 Failed: 6) Failed tests: 3, 6-9, 11 Non-zero exit status: 6 Files=1, Tests=18, 2 wallclock secs ( 0.05 usr 0.01 sys + 0.82 cusr 0.15 csys = 1.03 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/