https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735
--- Comment #40 from David Gustafsson <[email protected]> --- Thanks for the review. I obviously failed to manually test the opac-view, this is now fixed (the array for the in-condition should have been passed by reference). Regarding the failing tests, it's surprising so many are failing. I pretty sure I originally ran through them successfully, so it could be that those test regressions have been introduced after the rebase was performed, even though it seems odd regarding how many are now failing. I ran through those that failed for you on the current master, and got the following results: Passing: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/transferbook.t Failing: t/db_dependent/api/v1/checkouts.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation.t t/db_dependent/Illrequests.t t/db_dependent/Koha/Account/Line.t (foreign key constraint, could work on clean Koha with only test data) t/db_dependent/Koha/Items.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Letters/TemplateToolkit.t (Duplicate entry 'a_t_barcode', could work with test data) t/db_dependent/Reserves.t t/db_dependent/SIP/ILS.t (foreign key constraint, might work with test data) The ones passing also pass after applying the patches (though there were some changes in bug 32496 that should have been included here which I have now moved for transferbook.t to pass). I haven't used koha-testing-docker before, but could try to run the tests there and see if I get the same result (for koha-master). Feel free to do the same if you have the time I don't know how easy it will be to get it up and running. It could be that the current test suite is pretty broken, even though it seems odd this has gone under the radar regarding the number of failing tests. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
