https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #114 from Jonathan Druart <[email protected]> --- 1. FAIL Koha/Patron/Restriction.pm FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Patron/Restriction.pm FAIL Koha/Patron/Restrictions.pm FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Patron/Restrictions.pm 2. Koha/Patron/Restriction.pm:=head2 Relation accessors Why? This is not used anywhere else. We use "Class methods". 3. 64 <option value="[% code | html %]">[% PROCESS restriction_type_description %]</option> I think it's always better to pass the parameter, even if not needed => [% PROCESS restriction_type_description restriction_type => restriction_type %] Nothing considering blocker, passing QA. Please go ahead with bug 31458 and friends, I will be happy to QA them! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
