https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609
--- Comment #31 from Jonathan Druart <[email protected]> --- Thanks Martin and David, I've removed my patches and added yours to the remote branch. I have one concern about the `yarn install` step. At some point we want to freeze the node_modules directory, or we may get expected regressions at a very bad time. Imagine we are testing a beta version D-15 before the release, everything is working great, we decide to release on D-day, package maintainer releases using `yarn install && yarn build:prod`. If something changed in the node modules, we haven't tested it and we release a broken version. It's tricky and I don't have a solution right now, but we need to: * Let developers yarn install whenever they want (/kohadevbox/koha/node_modules will be used/tested) * Have a generated (when?) version (/kohadevbox/node_modules) that would be used to generate the compiled files on ktd startup (sandboxes and devs). We could run build:prod to avoid last minute bugs to popup. * Pick the last generated version for the release -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
