https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Jonathan Druart <[email protected]> --- + [% IF itemloop_has_images OR otheritemloop_has_images %] + KOHA.LocalCover.GetCoverFromItemnumber(true); + [% END %] This is not correct, that's not what we want here. You don't want to get the image at the item level if the *current* biblio has image at the item level. If you want to implement that you need to: 1. Create a new JS function in localcovers.js (say GetCoverFromItemnumberOrBibnumber) that would call opac-image.pl with a new parameter (say biblio-fallback=1) 2. Modify opac-image.pl to retrieve this parameter and return $item->cover_image || $biblio->cover_image The selenium test could also cover this situation :) Does that make sense? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
