https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
--- Comment #9 from Marcel de Rooy <[email protected]> --- (In reply to Jonathan Druart from comment #6) > 1. > The flags -clear, -reset and -renumber are mutually exclusive. > > Then I think the script should catch this situation. > > 2. I think we discussed that already, but there is more --confirm flags than > --dry-run in our scripts. It's confusing to have both. > > 3. You should remove references to 'verbose' in the module > > 4. Path to structure depend on cwd, we can do better. > > % cd misc/maintenance > % perl sync_db_comments.pl --database koha_kohadev --reset > Exception 'Koha::Exceptions::FileNotFound' thrown 'File not found' with > filename => installer/data/mysql/kohastructure.sql > > 5. use Data::Dumper (x2) Thx for your feedback. I definitely like --dry-run but will invert the cmdline flag to --confirm. Removing verbose from the module, although I do not think it is necessary. Other observations addressed too. Will resubmit. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
