https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32916
--- Comment #8 from Janusz Kaczmarek <[email protected]> --- (In reply to Frank Hansen from comment #6) > (In reply to Janusz Kaczmarek from comment #3) > > > > I would be curious to hear the opinions of those involved in the creation of > > the bug fix 30280. > > The main purpose of fix 30280 is to make Koha to distinguish authority > records for subject headings (6XX fields) based on thesaurus. The fix is > not made for non-6XX fields. > > However, as you mention, Koha hardcodes non-6XX fields to 'lcsh' (which is > equivalent to subject-heading-thesaurus = 'a'). This means that all > authority records must coded as lcsh. So yes, we need to do something about > it. According to https://www.loc.gov/marc/bibliographic/bdx00.html indicator > 2 is undefined for 1XX, 7XX and 8XX fields. I saw you changed it to undef > which is probably fine, unless it has other side effects. > > So, we only care for thesaurus value for the 6XX fields and skip filtering > on based on thesaurus for non-6XX fields. I have chosen to make a slightly > different solution for this. In C4::Heading_search I check if indicator 2 > has a value and is not blank. If it has a value, the filtering is performed > on the thesaurus. But if it is empty, i.e. has a space, no filtering is > performed. I made a fix for that, which I also mentioned in comment 58. I > provide my fix as a comment so you can see how I made it. But it still > doesn't solve the problem with Zebra and how it filters terms on the > thesaurus. > > My experience was that the thesaurus filtering in Zebra did not work after > all, even though it was said to work. The same term from different thesauris > were considered duplicates. So I wonder if something is broken here? > > I really have no opinion on whether our thesaurus index should be called > system-heading-thesaurus or system-heading-thesaurus-conventions. As long as > it doesn't create confusion into thinking that the system-heading-thesaurus > only contains 008/11, but also 040f. OK, I have tried your new proposal (BTW, there are two versions in the comment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32916#c7 ? I was able to apply only the first one). I seems that it does not change much -- from my supplied test set only the three '[Ff]eminism' and 'Subject lcsh' are linked correctly, and only under ES. Nothing under Zebra and also under Elastic the rest of headings remains unlinked. So -- no visible change. I fully understand the need to distinguish between thesauri while linking but we should not fix one thing and at the same time make other aspects not function. Earlier, under Zebra, there was no functionality to distinguish the thesauri nor other aspects of authority 008 field while linking therefor it should be fixed as well. And we cannot assume not force users to use 008/11 ='a' for authorities intended for biblio fields =! 6XX -- especially when 008/15 = 'b', 008/11 does not play any role. Have you tested my second proposal? Didn't it work for you? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
