https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <[email protected]> --- (In reply to Katrin Fischer from comment #8) > There are some small 'glitches' here: > > * The email option is visible even if the patron has no email address. But: > this matches the current behavior as the initial email is also created in > any case. So if we want to fix this, we should probably do it on a separate > bug and catch the initial email and the resend one at the same time. > > * When we resend an email from notices tab (look at the preview of a failed > notice, 'resend' button on the right), we resend the original notice. This > feature creates a new notice. I think this is ok, since we don't have the ID > of the original notice and it's not a big issue to have a separate one, it > might even be good to give more history. * Code duplication: the code for sending the notices is not duplicated in Account.pm and boraccount.pl. This is not ideal. It might be better to move it into a separate method and call it from both places? Setting to failed QA for feedback. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
