https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859
--- Comment #28 from David Gustafsson <[email protected]> --- (In reply to Katrin Fischer from comment #24) > Testing... > > 1) QA test tools > > FAIL > koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ > search_result_marc_export.inc > FAIL filters > missing_filter at line 14 ( <li>[% format %]: <a > href="[% > report.export_links.$format | $raw %]">[% report.export_links.$format | html > %]</a></li > > 2) Database update > > It would be better to use the new template for system preferences, but the > output should include the names of the new preferences. > > 3) System preference definitions > > a) This needs to be 0/1 instead of yes/no: > + - pref: EnableSearchResultMARCExport > + type: boolean > + default: yes > + choices: > + yes: Enable > + no: Disable > > > b) This doesn't read quite right: > "A format have the required properties \"<strong>name</strong>\", > \"<strong>fields</strong>\" and an optional > \"<strong>multiple</strong>\".<br />" > > c) SearchResultMARCExportCustomFormats > It says MARC export... but do we actually export MARC? Maybe a note where to > find the filed names would help here. From the name, I had expected MARC > fields. > > d) ElasticSearch should be Elasticsearch > > e) As this appears to be an Elasticserach only feature, all relating prefs > should say so. Also you might want to add some links from one pref to the > others involved. > > I got to stop here now since Elasticsearch doesn't want to cooperate in my > koha-testing-docker environment right now :( Thanks for the feedback! The issues should now be fixed. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
