https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
--- Comment #26 from Marcel de Rooy <[email protected]> --- (In reply to David Nind from comment #25) > I managed to get through the test plan - there were no changes in step 3, so > n changes in step 7 (if I did it correctly). That should be fine. > I think I tested it correctly, if not I hope QA and those more familiar with > what is going on review it. Great! > For the (QA follow-up) Improve finding schema file (see comment #19), I'm > not sure I did it correctly/what to expect. In KTD the file is in > installer/data/mysql rather than intranet/cgi-bin/installer/data/mysql. I: > 1. Renamed the file (mv installer/data/mysql/kohastructure.sql > installer/data/mysql/renamedkohastructure.sql) > 2. Ran the command misc/maintenance/sync_db_comments.pl -schema > kohastructure.sql > ==> output is: > Usage: > perl sync_db_comments.pl [-h] [-v] [-schema FILE ] [-database > DB_NAME] [-table TABLE_NAME] [-commit] [-clear|-reset|-renumber] > 3. If I run with the renamed file, the output is the same. Yeah, the schema parameter was not yet in the cmdline script. And that was a bit confusing. So I added a follow-up for it here after all. If you specify a wrong file now, it warns you: $misc/maintenance/sync_db_comments.pl -schema notexist File notexist not found! Usage: perl sync_db_comments.pl [-h] [-v] [-database DB_NAME] [-table TABLE_NAME] [-schema SCHEMA_FILE] [-commit] [-clear|-reset|-renumber] And when I add the reset option, you will see: $misc/maintenance/sync_db_comments.pl -schema notexist -reset File notexist not found! -- DRY RUN Exception 'Koha::Exceptions::FileNotFound' thrown 'File not found' with filename => notexist When I run with an existing file without reset|clear|renumber, you will not see the warn, only the usage. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
