https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148149|0 |1 is obsolete| | --- Comment #5 from David Nind <[email protected]> --- Created attachment 149144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149144&action=edit Bug 33210: (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee After resolving Bug 31963 everything works as expected when there is hold fee defined (!= 0). But in case when the fee for given patron category is set to 0.00, the user will always see the message "You will be charged a hold fee of 0,00 ...", which is obviously not intended. This is because categories.reservefee is returned from database as '0.000000' and as such, without type casting, is interpreted as string in Perl. Prior to Bug 31963 the result was compared to 0 before sending anything to the template, so the casting was done, now it is not. To test: ======== 1. Go to Administration -> Patron categories 2. Edit your patron category and give a hold fee of 0. 3. HoldFeeMode does not matter - you can set it to any value. 4. In another tab, open the OPAC. 5. Search the OPAC for any record with an item. 6. Go to place a hold on this record. You will see "You will be charged a hold fee of 0,00" --> This is a bug. 7. Apply patch and restart services. 6. Repeat step 6. 8. You should NOT see the hold fee message. Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
