http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218

--- Comment #15 from Bernardo Gonzalez Kriegel <[email protected]> ---
Hi Christophe,
now it works well :)

A few things more (sorry):
1) in C4/Charset.pm, the line with SanitizeEntity has a tab, replace it with
spaces.

2) in C4/Charset.pm are pod errors, you could write this as 
=head2 SanitizeEntity

  SanitizeEntity($marcrecord);

Sanitize Entity

=cut

BTW, description is a little short :)

3) in C4/Charset.pm, you put this function at the bottom. As an exported
function I think it must be moved up, below nsb_clean.

4) Important: make your script executable, only run if you do "perl
misc/maintenance/batchSanitizeEntity.pl"

5) You can change '===' with '---' so koha-qa do not complain. 
Not important really (rebuild_zebra has lots)

6) The confirmation question could be 'Proceed? [yes/no]'

I think that 1-4 could make this fail QA, 5-6 are suggestions.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to