https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <[email protected]> --- Overall this looks good, but we got one blocker: 1) Unit tests are missing. 2) I wonder if we could simplify the system preference description a little: Use the following patron email fields in order of highest precedence first [email|emailpro|B_email] when selecting which email address to use to send patron notices. 2 things: * I think we should list the valid options in the system preference so that when one was deleted, it can be restored more easily. * I have no idea how to translate highest precedence... but what it means is that the first field with an email address will be used, right? Maybe we could phrase it along the lines of: When EmailFieldPrimary is set to 'first valid', check the patron email address fields in the following order and use the first valid email address found: * Not blocker: For languages we can sort the entries with drag&drop. Could this be a possible option here? Or maybe I could file as a separate bug? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
