https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <[email protected]> --- Hi Nick, this looks quite good, but I think we need some more clean-up: 1) Serials C4/Serials.pm: if ( C4::Context->preference("RenewSerialAddsSuggestion") ) { require C4::Suggestions; C4::Suggestions::NewSuggestion( { 'suggestedby' => $user, 'title' => $subscription->{bibliotitle}, 'author' => $biblio->{author}, 'publishercode' => $biblio->{publishercode}, 'note' => $note, 'biblionumber' => $subscription->{biblionumber}, 'branchcode' => $branchcode, } ); } 2) Export list C4/Suggestions.pm: NewSuggestion Method is still in the list of exports. I would have fixed 2) but I think it would be better if you check on 1). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
