https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Jonathan Druart <[email protected]> --- (In reply to Pedro Amorim from comment #4) > It doesn't fix the "show mine only" being punted to the left, this is > because it's getting a float:left also from being a child of <fieldset> > (which is also causing the table to not be full width). > > The problem is <EHoldingsPackageAgreements> sits inside a <fieldset> in > EHoldingsEBSCOPackagesShow.vue. > > Then, in EHoldingsEBSCOPackageAgreements.vue we're opening the modal that > has <AgreementsList> inside it, but that modal is already a child of the > aforementioned <fieldset> so it's inheriting its style unintendendly. Fixed in the last version of the patch. > There is also another problem: the modal needs a overflow (and perhaps a > max-height?). If we have many agreements created, the modal overflows the > screen and doesn't let the user scroll vertically. I would suggest to deal with that on a separate bug. I think we need a separate component for modal, in which we will deal with this issue (we use .modal in a couple of places already) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
