https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478
Nick Clemens <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Needs Signoff |Failed QA --- Comment #24 from Nick Clemens <[email protected]> --- I didn't do a full run through as I hit a few issues. Must fix: - A patron without permissions cannot save print notices. The current settings need to be included as hidden inputs - The permission doesn't prevent url/form manipulation without the permission. This must be checked in the code. - There is an empty value in the Units dropdown for 'AGATE' Should fix: - The DB fields should be enum if they only support a limited range of values - This reveals an consistency - ISSUESLIP is presented in print format, however, it uses the 'email' template. Possibly the settings can be their own section? Otherwise this needs to be addressed - 'Apply format settings to all notices' - I can see the utility here for initially settings things up - but this seems a bit too powerful. A warning at least would be nice - Even if you cannot edit the settings - it would be useful to view the print formatting so you know what you can see - The new form is added to all notices - but it really only applies to slips if I understand correctly? Does this work with bug 33260 for printing notices from the staff interface? It should be clarified if it does not work with gather_print_notices etc. Could fix: - I don't know that a permission is needed here, if you can edit slips I would assume you can edit this portion too, but I assume there is a motivation -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
