http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from M. de Rooy <[email protected]> --- QA Comment: koha-qa is happy. Optional dependency is added. In the above comments there was a discussion if the script should start running if passed no parameters. For the record, I just note that it still does. (Not a blocker.) Available time does not allow me to dive into the details of PPI, TAP, etc. for now. In order to really say something about this code, someone probably should. But that might block this patch for long time.. (Pushing this isolated test script will not hurt anyone :) I still have three questions: 1) When running the script, I have lots of warnings like "No plan found in TAP output". For instance for admin/import_export_framework.pl. Could you please clarify? Is this just a false positive? 2) For some other scripts, a reference is made to failed tests. E.g. acqui/basketgroup.pl: Failed tests: 7-9. As I understand, these should refer to not exported subroutines. How can I find which ones? Are they routines in one of the 'used' modules? Documentation is not very clear. Naming the routines would be very helpful. Note that running the script without parameters will delete the temp dir right away; so I cannot check it. 3) The usage statement says: For more information, open the file with a text editor.. Which file? I would like to pass qa on this patch. It has been here already too long. It may need some follow-ups to provide more useful information, but that should not block pushing this patch. But before doing so, I would like to see your answers on the above three questions. For that reason I set this patch to Failed QA. After receiving your answers, I will update the status again and add a signoff. Thanks. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
