https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844
Emily Lamancusa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #60 from Emily Lamancusa <[email protected]> --- Hi Aleisha, I encountered a few errors while trying to test this patchset. #1 After changing RevertLostBibLevelHolds to "Revert", I get the following error on cataloguing/additem.pl: The method Koha::Items->holds is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572 Koha::Objects::AUTOLOAD('Koha::Items=HASH(0x564bf159f540)', 'HASH(0x564bf1743f18)') called at /kohadevbox/koha/cataloguing/additem.pl line 757 eval {...} at /kohadevbox/koha/cataloguing/additem.pl line 2 The error persists even if I change RevertLostBibLevelHolds to "Don't Revert" and restart all. (It does not occur before I change the syspref, and does not persist if I reset all.) --------------------------------------------------------------------------------- #2 I get the following error on moredetail.pl: Can't call method "holds" on an undefined value at /kohadevbox/koha/catalogue/moredetail.pl line 251 The line in question is: $item_info->{waiting_holds} = $item->{object}->holds({ found => [ 'W', 'T' ], item_level_hold => { '!=' => 0 } })->count; I tried replacing "$item->{object}->holds" with "$item->holds" and that seemed to fix it (and had no effect on error #1). --------------------------------------------------------------------------------- #3 Tests don't pass: t/db_dependent/Reserves.t .. "my" variable $item masks earlier declaration in same scope at /kohadevbox/koha/C4/Circulation.pm line 4029. t/db_dependent/Reserves.t .. 24/78 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 588. t/db_dependent/Reserves.t .. 73/78 # Looks like you planned 17 tests but ran 13. # Failed test 'Waiting item is marked as lost' # at t/db_dependent/Reserves.t line 1563. Can't call method "notice_email_address" on unblessed reference at /kohadevbox/koha/C4/Message.pm line 185. # Looks like your test exited with 11 just after 73. t/db_dependent/Reserves.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 6/78 subtests -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
