https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730
--- Comment #18 from Marcel de Rooy <[email protected]> --- $paton->get_lists_with_patron Looking at package Koha::List::Patron, it feels to me that it better should live there. No absolute blocker. That package is no Koha::Object btw. Explaining probably too why you add DBIx code Seeing some calls that only need the count of this result btw. +<div class="patroninfo-section"> + <h4>Patron lists without this patron</h4> Looks like this section contains a lot of duplicated code? Could probably be merged in some named block. Not sure why we need two tables, but that seems just a matter of taste. @available_lists = GetPatronLists(); @available_lists = grep { ! $list_id_lookup{$_->patron_list_id} } @available_lists; [...] in_lists => \@in_lists, list_id_lookup => \%list_id_lookup, available_lists => \@available_lists, This makes me even more wonder why we are using get_lists_with_patron. You are selecting the reverse here? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
