http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Jonathan Druart <[email protected]> --- (In reply to comment #3) > QA Comment: Hello Marcel, > This looks quite good. Code improvement! koha-qa is happy too :) > A few minor details needing some attention: > > 1) Circ $error->{message} = "on_reserve"; Should be just $error= > "on_reserve" Yep, good catch! Will be fixed. > 2) GetReserveStatus needs some error checking to prevent warnings on > $found/$priority at the end (if there is no reserve) Will be fixed too. > 3) IsAvailableForItemLevelRequest: the check GetReserveStatus($itemnumber) > eq "W" is replaced by $status eq "Waiting" or $status = "Reserved" > Please clarify. As I understand, AllowOnShelfHolds is OFF here. So the > second part of the check should be: AND Is it on loan or waiting (current > behavior)? > You could even argue that you should test only for on loan.. > Why do you add Reserved? You are right too, I don't find any reason. The test should only be on "Waiting". > Please send a followup. I will gladly sign off on that.. It's coming... -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
