https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |[email protected] QA Contact|[email protected] |[email protected] | |y.org --- Comment #22 from Marcel de Rooy <[email protected]> --- (In reply to Michael Hafen from comment #21) > Comment 8 on this bug mentioned the method name, but only that it needed to > be snake case, which it now is. > > Same comment also mentioned the get_lists_with_patron() method and suggested > putting it in Koha/Patron. I'm fine either way; as a Patron method it would > need a Patron object, as a List method it would need the borrowernumber or > patron object passed as a parameter. Either way works for me. > > There is a lot of apparent duplication in the patron lists tables, but there > is a purpose. It's mostly for convenience. One table show the lists the > patron is in, and needs the get_lists_with_patron() call. The second table > shows the available lists the patron is not in; this is for the convenience > of quickly adding the patron to one of those lists. So it calls get_lists() > and then culls out the lists the patron is already in. If this convenience > is deemed to system heavy to be feasible it can be pulled out. Or the > second table could be reduced to a drop down with list names. > > This package isn't a Koha Object, as you noted, so there's a lot of DBIC. > The specialized nature of some of those methods, in that they have to dig > into the patronlistpatrons table, makes me think that's the best way to > handle it either way. I don't think get_lists_with_patron() could be done > efficiently without going to DBIC. > > I'd like to see some suggestions for a better method name, I think it's got > a pretty good name myself. It's very descriptive. Thanks for your feedback. Tomas may be in a better position to provide further clarification of his commments. I am moving this one back in the SO queue to get another QA perspective. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
