http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9457
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED CC| |[email protected] | |m --- Comment #4 from Jonathan Druart <[email protected]> --- QA comment: Great patch Bernardo! And great test plan too, it is really pleasant to test. I just found a little (big?) stuff. You forget to test (at several places) if C4::Context->userenv exists before to access to the 'branch' key. Sometimes this hashref (C4::Context->userenv) is not defined and the user get a software error. I think there is just one case: if the insecure syspref is turn ON. *But* I suppose this feature is broken, so are there actually someone using it? (I suppose that because of there are already several places where this test does not exist (e.g. reserve/request.pl)). So there are 2 possibilities: 1/ You send a mail to koha-devel in order to know if this feature can be deleted (in this case, we open a new report for that). 2/ You submit a followup taking account of this syspref. Switch the status to in discussion. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
