http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241
M. de Rooy <m.de.r...@rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #34 from M. de Rooy <m.de.r...@rijksmuseum.nl> ---
QA Comment:
This patch deserves to be pushed soon, but I am still having doubts on the
following:
1 You remove the timestamp on update. Why? If you do not want to change the
timestamp when correcting the old log lines, remove the timestamp temporarily
on update and put it back when you are ready. Or try adding timestamp=timestamp
in your update statement (did not test that).
I think we should keep the on update clause (in terms of consistency).
This would mean that you leave kohastructure unmodified.
2 Many people already commented on the old log lines. You choose the first item
as a workaround. (Another approach could have been: Delete information that is
incorrect, or somehow route the old lines to biblio detail and the new ones to
item detail, perhaps adding biblio to info field for old ones.)
It is somewhat arbitrary. But could you at least add a separate print line in
the updatedatabase output warning the sysadmin about this?
Please send a followup and switch back to Signed off.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
