https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #143 from Katrin Fischer <[email protected]> --- Overall this is mostly small stuff, apart from 9) maybe! We'll also need some good documetnation, but the test plan in comment 121 is a good start. 1) Perltidy Should we perltidy the new files at least? 2) System preferences - sysprefs.sql sysprefs.sql is supposed to be alphabetic (being a librarian, this is not acceptable! ;) ) ('ConfirmFutureHolds','0',... +('CookieConsentedJS', '', NULL, 'Add ... ('ConsiderOnSiteCheckoutsAsNormalCheckouts',... ('ContentWarningField', '',... +('CookieConsent', '0', NULL... 3) System preferences - YAML a) + - pref: CookieConsent + choices: + yes: Require + no: "Don't require" + - cookie consent to be displayed Should be 1 and 0. (blocker) Should we rephrase a bit? ... cookie consent to be displayed in the OPAC and staff interface. Question: Could it be interesting to make this OPAC only in the future? b) Add Javascript code that will run if cookie consent is provided (e.g. tracking code). Should we rephrase this a little? Run the following JavaScript if cookie consent was provided (e.g. tracking code): 3) Add to cookie documentation please https://wiki.koha-community.org/wiki/Use_of_Cookies For OPAC and staff interface. 4) Translatability (blocker) ' <a class="consentDelete" data-target="' + id + '" href="#">Delete</a>' + 5) Test plan and comments Giving that this is an old development there are quite some inconsistencies in what is the final product and what is mentioned in the commit messages. Like we started out with 4 prefs and now 2 are HTML customizations. Some squashing and clean-up could be really helpful I think. But: great updated test plan in comment 121 ! 6) Display issues a) In the OPAC, the cookie banner overlaps and blocks access to the language selection at the bottom. If you have them at the top too, that's ok, but some libraries prefer one over the other ( OpacLangSelectorMode = only footer ). b) In the staff interface we have the language chooser in front, cutting off a bit of the "Accept all cookies" button. c) In the OPAC readability (font color and size) is good, but in the staff interface it's much less readable. 7) Patron account a) It doesn't appear to be possible to revoke the general cookie consent? b) The contrast on the yellow "Accept selected non-essential" cookies seems bad (greyish font color on yellow background) c) Should the button read "View and update..."? d) I cannot close/cancel the modal without making a change. Clicking outside, pressing ESC, nothing works. We shoudl have a "Cancel" link. This is also true when using the "your cookies" link for a non-authenticated user. 8) Visibility OPAC/staff a) I checked one of the cookies for only OPAC and one only for staff interface. I still see all 3 cookies in the pop-up in both OPAC and staff after clearing local storage. b) This might be related: test2 is my "staff only" cookie. It's unchecked in the view, but it still gets added every time I refresh any OPAC page. Same for my "opac only" cookie: it's always added in staff interface on page reload. c) Where can staff view and alter their cookie consents? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
