https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34182
Bug ID: 34182
Summary: AddBiblio shouldn't set biblio.serial based on
biblio.seriestitle
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs@lists.koha-community.org
Reporter: p...@chetcolibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: katrin.fisc...@bsz-bw.de, m.de.r...@rijksmuseum.nl
Back in the 3.0 days, in
https://git.koha-community.org/Koha-community/Koha/commit/af466ca41ab02150f4f6c60bf6262b079b2e6e85
someone looked at the dead code in
https://git.koha-community.org/Koha-community/Koha/blame/commit/c6013f3fd09ac5bd02f31e86bcc932c265c58502/C4/Biblio.pm#L3288
my $series = 0;
if ( $biblio->{'seriestitle'} ) { $series = 1 }
which did nothing because there wasn't any biblio.series for $series to be
setting (maybe there had been at one time, maybe it was always dead code,
dunno), and decided to "fix" it by changing it to
# set the series flag
my $serial = 0;
if ( $biblio->{'seriestitle'} ) { $serial = 1 };
which turned it into actively wrong code, overriding someone actively setting
serial with whether or not it had a series title. A few years later, someone at
least let setting something mapped to biblio.serial cause biblio.serial to be
set, while leaving the bogus setting of it based on seriestitle still there if
serial wasn't already set.
The added comment "# set the series flag" makes it clear that it wasn't done
out of any belief that seriestitle implies serial, only thinking that serial
was how you spell "has a series."
As bug 34128 will tell you, it isn't. And since CheckPrevCheckout uses
biblio.serial to only warn people if they have previously checked out a
particular copy of People Weekly rather than warning them that they checked out
last week's issue so they don't want this week's issue, had it noticed that as
a result of seriestitle -> serial it doesn't warn people who've checked out
copy 1 of the 62nd Stone Barrington novel that they probably don't want to
check out copy 2, CheckPrevCheckout would also tell you that it isn't.
For comic relief, AddBiblio only sets biblio.serial the first time that you
save a biblio which has a seriestitle. If you edit the biblio again, ModBiblio
unsets it, so it's both wrong and incapable of making its wrongness stick.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
