https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862
--- Comment #11 from Katrin Fischer <[email protected]> --- (In reply to Katrin Fischer from comment #10) > > You might ignore this remark looking at e.g. 856(In reply to Marcel de Rooy > > from comment #8) > > <xsl:attribute name="href"><xsl:value-of select="text()"/></xsl:attribute> > > You might need to str-encode-uri and normalize-space stuff here. > > Something like (do not copy): > > <xsl:value-of > > select="str:encode-uri(concat($scriptname,'?q=ti,phr:', > > translate($quoted_title, '()', '')),false())"/> > > <xsl:value-of > > select="normalize-space(marc:subfield[@code=$cnum_subfield])"/> > > This part pre-dates my patch, I can have a look at 856. I had a look, but I am not sure this applies here. $u is a full URL here, not a parameter we use to build a search URL, so there should not be a need to encode it - it might even break things if it's already encoded. Do you agree? > > Why do you open a new window in OPAC (pref dependent) and not in staff? > > Could imagine that staff could have it. > > Because we don't have an equivalent of the pref for the staff interface and > we don't use the OPAC one in staff either. I stumbled on that too when > working on the patch, should maybe have left a note :) See: Bug 29739 - Add a staff counterpart for OPACURLOpenInNewWindow Currently we only open the "OPAC" link and the links to authorities in a new tab, so behavior is consistent with this patch, even if it could be improved. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
