https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #65 from Marcel de Rooy <[email protected]> --- Tomas, this is weirdL WARN Koha/Statistic.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 1, now: 12) File has been tidied. But if I tidy it again, it generates this diff: diff --git a/Koha/Statistic.pm b/Koha/Statistic.pm index 217f378ab0..e37d1b88f7 100644 --- a/Koha/Statistic.pm +++ b/Koha/Statistic.pm @@ -27,9 +27,9 @@ use Koha::PseudonymizedTransaction; use base qw(Koha::Object); -our @allowed_accounts_types = qw( writeoff payment ); -our @allowed_circulation_types = qw( renew issue localuse return onsite_checkout recall item_found item_lost ); -our @mandatory_accounts_keys = qw( type branch borrowernumber value ); # note that amount is mapped to value +our @allowed_accounts_types = qw( writeoff payment ); +our @allowed_circulation_types = qw( renew issue localuse return onsite_checkout recall item_found item_lost ); +our @mandatory_accounts_keys = qw( type branch borrowernumber value ); # note that amount is mapped to value our @mandatory_circulation_keys = qw( type branch borrowernumber itemnumber ccode itemtype ); =head1 NAME @@ -103,18 +103,18 @@ sub new { return $class->SUPER::new( { - datetime => Koha::Database->new->schema->storage->datetime_parser->format_datetime(dt_from_string), - branch => $params->{branch}, - type => $params->{type}, - value => _key_or_default( $params, 'value', 0 ), - other => _key_or_default( $params, 'other', q{} ), - itemnumber => $params->{itemnumber}, - itemtype => _key_or_default( $params, 'itemtype', q{} ), - location => $params->{location}, + datetime => Koha::Database->new->schema->storage->datetime_parser->format_datetime(dt_from_string), + branch => $params->{branch}, + type => $params->{type}, + value => _key_or_default( $params, 'value', 0 ), + other => _key_or_default( $params, 'other', q{} ), + itemnumber => $params->{itemnumber}, + itemtype => _key_or_default( $params, 'itemtype', q{} ), + location => $params->{location}, borrowernumber => $params->{borrowernumber}, # no longer sending empty string (changed 2023) categorycode => $params->{categorycode}, ccode => _key_or_default( $params, 'ccode', q{} ), - interface => $params->{interface} // C4::Context->interface, + interface => $params->{interface} // C4::Context->interface, } ); } -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
