https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33940
--- Comment #6 from Marcel de Rooy <[email protected]> --- - # If cardnumber is null, we assume they're allowed. - return 0 unless defined $cardnumber; + return Koha::Result::Boolean->new(0)->add_message( { message => "is_empty" } ) + unless defined $cardnumber; The former routine returned 0 meaning OK. The new routine returns 0 meaning false. You are changing behavior. Mabye I just dont wanna use cardnumber. Not sure if it is needed to make a distinction here btw between null and empty string. Currently, message => "is_empty" should read is_undefined. We miss tests for this situation. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
