https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34338
--- Comment #7 from Jonathan Druart <[email protected]> --- (In reply to Marcel de Rooy from comment #5) > koha-tmpl/intranet-tmpl/prog/en/includes/onboarding_messages.inc > Card number contains whitespaces > > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt > Cardnumber already contains whitespaces. > > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt > [% ELSIF cardnumber_not_trimmed %] > <a href="#borrower_cardnumber"><strong>The entered card number contains > whitespaces.</strong></a> > > Three different strings. > And they are not exact. We dont like leading or trailing whitespace. Fixed. There are still 2 different messages, to match the other strings in the same files. (In reply to Marcel de Rooy from comment #4) > (In reply to Jonathan Druart from comment #3) > > Hum see comment 1. What's the expected behaviour? Should we keep the "if > > blank treat as null" in memberentry.pl for staff, but reject in other > > places? > > No we should reject it too. It's not clear to me if we want to introduce a behaviour change here. > But something strange is going on here in the direct context: > > my $new_barcode = $newdata{'cardnumber'}; > Koha::Plugins->call( 'patron_barcode_transform', \$new_barcode ); > > $newdata{'cardnumber'} = $new_barcode; > > That is interfering with our new logic here. > Does not look good to me. I don't understand what you mean, can you explain a bit more? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
