https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805
--- Comment #10 from Katrin Fischer <[email protected]> --- Comment on attachment 153185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153185 Bug 28805: Add on-site checkout checkbox in batch checkout Review of attachment 153185: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28805&attachment=153185) ----------------------------------------------------------------- Hi Fabricio, thanks for working on this! Joubu already made 2 good points, I have a bit of an explanation and one more: ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt @@ +99,4 @@ > </li> > </ol> > </fieldset> > + [% IF Koha.Preference('SpecifyDueDate') && > Koha.Preference('OnSiteCheckouts') %] To explain a bit more what Jonathan said: the specify due date feature and the onsite-checkout only partially depend on each other. So this should probably be split into separate conditions or be ||. * If you have both, you are able to change the pre-selected due date for the on-site checkout. * If you have only OnSiteCheckouts, the date is automatically set to today 23:59:00 in the background. * Only SpecifyDueDate works like now. You can compare how it should work with the same options on the checkouts tab. @@ +104,5 @@ > + <legend>Due date:</legend> > + <label for="duedatespec">Hard due date: [% INCLUDE > 'date-format.inc' %]:</label> > + <input type="text" size="20" id="duedatespec" name="duedatespec" > value="[% duedatespec | html %]" class="flatpickr" > data-flatpickr-enable-time="true"/> > + <div id="onsite_checkout-select" class="circ-setting"> > + <div class="circ-setting"> You double-up the circ-setting classes here in 2 different div - this makes the font size smaller than for the other options. Maybe one or both should be removed. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
