https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |[email protected] QA Contact|[email protected] |[email protected] |y.org | --- Comment #6 from Victor Grousset/tuxayo <[email protected]> --- weird, with and without the patch I'm hitting this error with MySQL8 before getting to the part relevant to this ticket: koha-koha-1 | DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: DBI connect('database=koha_kohadev;host=db;port=3306','koha_kohadev',...) failed: Authentication plugin 'caching_sha2_password' reported error: Authentication requires secure connection. at /kohadevbox/koha/Koha/Database.pm line 91. at /kohadevbox/koha/Koha/Database.pm line 139 koha-koha-1 exited with code 1 Does that speak to anyone? ktd repo, koha code, ktd images up to date **Anyway**, it works for Kyle and David and the change is trivial, there is enough confidence to not block on my dev env issue. And with the patch, it still works for me with MariaDB. And this will be the CI which fails on the right issue so it should be fixed. So: Makes sense, QA script happy[1], code looks good, passing QA :) [1] waived this perltidy warning: ``` $dbh->do(q{ ALTER TABLE tmp_holdsqueue CHANGE COLUMN itemnumber `itemnumber` int(11) NOT NULL }); ``` ↓↓↓↓↓ ``` $dbh->do( q{ ALTER TABLE tmp_holdsqueue CHANGE COLUMN itemnumber `itemnumber` int(11) NOT NULL } ); ``` The proposed code is following our two examples: https://wiki.koha-community.org/wiki/Database_updates minor tangent question: @Kyle, @Tomas Maybe they should be changed or it's not a big deal to have this warning on each new db rev? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
