https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|[email protected] |[email protected] |y.org | Status|Signed Off |Passed QA CC| |[email protected] --- Comment #4 from Victor Grousset/tuxayo <[email protected]> --- > - In the filter field at the top of the table, enter a string which > will not be found. You should see a message, "No matching reports > found." Without the patch, I got "No matching reports found" translated in french with fr-FR enabled. But that shouldn't be the case, right? Isn't that's also what the patch is supposed to fix? (given the code change) Ok, it seems that "No matching reports found." works regardless. But the way it's implemented influences whether the pagination and search are translated. Very very weird. It seems that's how it's is 🤷 Works, makes sense functionally, QA script happy, code looks good, passing QA :) Gotcha when testing: if doing back and forth between with a without the patch, don't forget to redeploy the translation each time! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
