https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34713
Julian Maurice <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Julian Maurice <[email protected]> --- I don't think the distinction between filters and actions is that important. A plugin method can do both. For instance an item_barcode_transform hook can modify the barcode, or log it somewhere, or both. Sure, the caller sometimes expects the plugin to act as a filter (like item_barcode_transform) but most of the times it does not expect anything. It's more like "This event just happened (or will happen right now), do what you want with that info" I think standardizing name cannot be a bad thing, but the thing that matters the most (to me at least) is a proper documentation of the hook arguments: what they contain and if (and how) they are used after the hook returns. In some implementations of an event manager, the event listener (the hook) gets an object acting as a container for the event and its parameter. Maybe we can take inspirations from that to standardize the hook signatures. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
