https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34768
--- Comment #1 from Nick Clemens <[email protected]> --- Created attachment 155558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155558&action=edit Bug 34768: Remove checkbox column from relatives fines on OPAC When a patron has a guarantee and can see their fines on the opac and an opac payment plugin is enabled there is an error on the 'Charges' tab. The table uses a 'COLSPAN' variable which is set to 5 or 6 depending on if OPAC payments are enabled. The guarantees table has one less column than the patron's however, so it is going out of range and causing a JS error. Additionally, we are adding a column to the child's table which is not used as their fines cannot be selected for payment at this time. This patch removes the checkbox column and sets the colspan directly to 4 I also fix an issue where the table is not being set as we need to reference the patron object in the guarantor info to obtain the id. To test: 1 - Set system preference: AllowStaffToSetFinesVisibilityForGuarantor to allow 2 - Find a patron 3 - Add some fines to their account 4 - Install and enable an opac payment plugin (https://github.com/bywatersolutions/koha-plugin-pay-via-govolution for example) 5 - Sign in to OPAC as borrower 6 - Go to 'Charges' tab 7 - Select a fee 8 - Confirm 'Make payment' button enabled and 'amount to pay' is updated 9 - Add a guarantee to patron in staff interface 10 - Set 'Show charges to guarantors' to 'Yes' 11 - Add and pay a fine for the child 12 - View guarantor account on the OPAC 13 - Confirm you now see child's charges 14 - Confirm selecting your own fees does not enable the button or update amount to pay 15 - Note JS error in console 16 - Apply patch 17 - Reload patrons page 18 - Confirm the table loads correctly (no JS error) 19 - Confirm selecting a fine updates the total and enables button 20 - Disable the payment plugin 21 - Confirm the display is still correct, no errors -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
