https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155299|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <[email protected]> --- Created attachment 155758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155758&action=edit Bug 34724: Remove inline onclick handler for opac-imageviewer.pl This patch moves the click handler for thumbnails for opac-imageviewer.pl out of the inline HTML and out to an existing <script> element. Test plan: 0. Apply the patch (including dependent patches) 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=localcover 2. Change both *LocalCoverImages sysprefs to "Show" 3. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=AllowMultipleCovers 4. Change "AllowMultipleCovers" to "Allow" 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 6. Click "Images (0)" tab 7. Download or make two JPEG images 8. Upload the images 9. Go to http://localhost:8080/cgi-bin/koha/opac-imageviewer.pl?biblionumber=29 10. See one large image in the centre and two smaller thumbnails on the right side 11. Click on the thumbnail of the image that isn't displayed in the centre 12. Note that the image changes 13. Click the other thumbnail and note that the image changes back PA amended patch: Added missing test plan step Signed-off-by: Pedro Amorim <[email protected]> Signed-off-by: Katrin Fischer <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
