https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33849
--- Comment #2 from Emmi Takkinen <[email protected]> --- (In reply to Emmi Takkinen from comment #1) > For some reason $op isn't set as "duplicate" (as it should if I understand > this correctly). So this condition isn't filled > Actually, $op shouldn't be "duplicate". It's "duplicate" if patron is added with "Duplicate" button. > if (defined ($data{'branchcode'}) and ( $op eq 'modify' || $op eq > 'duplicate' || ( $op eq 'add' && $category->category_type eq 'C' ) )) { > $userbranch = $data{'branchcode'}; > } > > and logged in users branchcode is used instead of selected branchcode. Why to we to this ( $op eq 'add' && $category->category_type eq 'C' )? Shouldn't we use existing branchcode for all patron categorytypes, not only for "C"? And now when I think about this, shouldn't we use existing branchcode no matter what value $op has? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
