https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Victor Grousset/tuxayo <[email protected]> --- (In reply to Katrin Fischer from comment #6) > You are right about the follow-up. I did intend to "move" the space outside > of translations, but forgot to remove it from the string. Good, I just needed a confirmation about this then, Works, makes sense, QA script happy, code looks good, passing QA :) --- (In reply to Katrin Fischer from comment #9) > I think the browser collapses 2 into 1 It indeed looks like that :) > I don't think this needs to be Failed QA? At first I was really not sure to have really found a mistake with the space thing. Hence the "maybe follow-up" and didn't know which status to use. Then I saw it seemed to come from Bug 15348 and got almost sure it was a mistake so Failed QA seemed to fit enough. But still needed a confirmation. Maybe "in discussion" fit better? --- (In reply to Caroline Cyr La Rose from comment #10) > I think Victor maybe wanted some feedback on the follow-up since it's called > "MAYBE FOLLOW UP ..." Yeah, either case it would have been able to move on after settling the space question. > Which is why I tried to test it with and without the follow up patch. I > don't see any difference in the .po file either. Thanks for retesting. > If it's only a clean code thing, it's fine since it doesn't change the > behaviour. > If it's meant to change the string, it's (maybe?) not working. In either case, the translatable string was without a leading space. Nice that it can avoid duplication of strings :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
