https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053

--- Comment #24 from Fridolin Somers <[email protected]> ---
(In reply to Emily Lamancusa from comment #19)
> Nice clarity improvement! is_expired looks good and works as expected - it
> just needs the unit test.
Here it is :)

> 
> Also, there's a typo in patron-restrictions-tab.inc:
> 37    [% IF restriction.is_expired %]<span>(expired)<span>[% END %]
> ^ The / is missing from the closing </span> tag
Good catch, yayk ;)

Also UT helped me to find an issue with expiration = today, one must use day
truncation like in Koha::Patron :
  dt_from_string->truncate( to => 'day' );

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to