https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968
--- Comment #4 from Marcel de Rooy <[email protected]> --- (In reply to Katrin Fischer from comment #3) > Why remove these tests? > > -use_ok('C4::Search'); > -can_ok('C4::Search', > - qw/_build_initial_query/); Calling use_ok does not really add anything to our tests (here and in general too). We have a specific test that tests loading all modules in C4 and Koha in t/00-load.t. It will signal such a module. If the module would not load (and it would still be signed off..), the specific test will fail too anyway. For me the BEGIN blocks with use_ok are just unneeded ballast. We have no coding guideline to keep them and not one to remove them. It should not be a blocker for this report imo. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
