https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829
--- Comment #8 from Marcel de Rooy <[email protected]> --- (In reply to Marcel de Rooy from comment #4) > my $branch = $input->param("branch"); > my $manager_branchcode = $input->param("branch") || > C4::Context->userenv->{'branch'}; > This does not look good. You added $branch here, but we already have $manager_branchcode using the same CGI parameter. We should not do that. It will create confusion. If you need to know the branch code passed, use the existing variable. Change that etc. Do not clone it. > And this looks bad: > - <option value="ALL">All</option> > Script still has it: > if ($manager_branchcode ne 'ALL') { In the template you remove the ALL value of a combo box. You replace it by: + <option value="">All libraries</option> But the script still contains reference to the old value ALL. You should also solve those references. HTH -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
