https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
Aleisha Amohia <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #69 from Aleisha Amohia <[email protected]> --- The attached patchset addresses the QA test tools and fixes the erroring test. I could not fix the POD and perltidy warnings about Koha/Schema/Result/Library.pm, Koha/Schema/Result/LibraryHour.pm, and Koha/Library/Hour.pm - any guidance on that would be appreciated. (In reply to Katrin Fischer from comment #59) > > 2) Terminology > > a) ConsiderLibraryHoursWhenIssuing = instead of issue we usually use > checkout, but maybe ConsiderLibraryHoursInCirculation would be a good fit? done > > b) We have Koha::Library::Hours.pm, but Koha::Schema::Results::BranchHour - > why not use LibraryHour and also library_hours for the table name? done > > c) Issuing should be 'checking out' in system preference description: > Take library opening hours into consideration to calculate due date when > issuing. changed to 'when circulating' to match the syspref name > > 3) Database update > > The 2 separate database updates for adding the pref and the table could have > been combined (not blocker). Done, QA tools complained about this too > > a) The code comments should be removed form the kohastructure.sql file. > > +/*!40101 SET @saved_cs_client = @@character_set_client */; > +/*!40101 SET character_set_client = utf8 */; > +/*!40101 SET character_set_client = @saved_cs_client */; done > > 4) Translatability > > Our scripts always look for strings inside of HTML tags. Wrapping these in > spans will make it much easier on translators and possibly allow to 'reuse' > the existing translations for week days from other parts of Koha. > > +[% BLOCK dayname %] > + [% IF day == 0 %] > + Monday > + [% ELSIF day == 1 %] > + Tuesday > + [% ELSIF day == 2 %] > + Wednesday > + [% ELSIF day == 3 %] > + Thursday > + [% ELSIF day == 4 %] > + Friday > + [% ELSIF day == 5 %] > + Saturday > + [% ELSE %] > + Sunday > + [% END %] > +[% END %] > done ... still WIP for the libraries summary page > > 5) Library administration > > b) It should also be present in the library 'view' page, that is accessible > if you don't have admin permissions. > http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL > Done > > a) The opening and closing times should also appear in the 'summary' table > of all libraries. (Don't forget to add to add to column configuration as > well!) > c) TimeFormat is set to 24h format, but I still get presented with AM/PM on > data entry. It also doesn't follow CalendarFirstDayOfWeek. I'd think the > first would be more important. Maybe the curbside pickup GUI could give some > ideas here as I think we did fix the TimeFormat issue there. These two requests have added a lot of complexity to this - adding new columns to an API generated table is not documented anywhere. I don't have capacity to work on this for a while, but maybe someone can build upon what I've done in the most recent patch. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
