https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35163
Bug ID: 35163
Summary: overdue_notices.pl wrongly reports "terms were not
matched and replaced"
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Command-line Utilities
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
I tried running overdue_notices.pl with the --verbose argument, and got a bunch
of messages like this:
The following terms were not matched and replaced:
div class="adress_odue"
div class="adressrad"
/div
...
But the generated messages in the message_queue looks ok. The message comes
from this code, around line 766 of misc/cronjobs/overdue_notices.pl:
my @misses = grep { /./ } map { /^([^>]*)[>]+/; ( $1 || '' ); } split /\</,
$letter->{'content'};
if (@misses) {
$verbose and warn "The following terms were not matched and replaced: \n\t"
. join "\n\t", @misses;
}
I have a hunch this is meant to look for things like <<something>> that are
still left in the $letter->{'content'}, but it actually finds and reports on
things like <something>, including HTML tags. So maybe it can be improved to
look for <<>>?
Maybe there should even be two different checks like this, one for HTML
messages and one for non-HTML-messages?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
