https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #22 from Jonathan Druart <[email protected]> --- (In reply to Blou from comment #21) > Did a quick check. There are .... a lot of them. > > One question: installer/data/mysql/updatedatabase.pl calls > C4::Context->preference, which is now an object call behind the scene. I > know updatedatabase is not the do-it-all anymore, but to ensure it still > works for years to come shouldn't we replace those calls by a local, > straight SQL call ? > > A few hundred calls to preference, and one to set_preference. > > > THAT SAID, pragmatism tells me to look for another way: Modify preference() > to use straight DB, and move all the calls to set_preference() and > delete_preference() to Koha::Config::Sysprefs. > > I'll test that in Bug 28411. Won't prevent major overhaul later, but seems > like a safe approach. Why do you want to remove C4::Context from updatedatabase? What would be the gain? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
