https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390
Emily Lamancusa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Emily Lamancusa <[email protected]> --- Generally the code looks good, and the dbrev is idempotent. One big concern, though - should all of the foreign keys be ON DELETE CASCADE? With the exception of additional_fields, the field is nullable, and when removing conflicts before applying the foreign key, the dbrev sets them to null. Shouldn't the foreign key constraint do the same if the authorized value is deleted? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
