https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <[email protected]> ---
This works, but there are some bigger and smaller issues:

1) It produces an invalid HTML file, missing the html and body tags. If we were
to add them to the template, the template could no longer be properly displayed
in Koha. That's why I feel it would be better to add those on export. It's
created with a .html ending, so I assume that is the use case.

2) The patch commit line needs to be fixed.

3) I think we should change the label in the download menu to fit with the
others. It's a list of formats now, never including the word "Download", so my
suggestion would be something like: "HTML using [template] '<template>'" 
If possible please avoid the <i> as they break up the string.

4) Perltidy please.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to