https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
--- Comment #50 from Katrin Fischer <[email protected]> --- Hi Jonathan, this was a quick return :) There are at least 2 points that give me some headache here in that it changes behavior in a way that will hurt library workflows. (marked DISCUSS). I think they need more time/thought and eyes on them before we are ready here. Librarians: We need you to tell us how you use this table! > > Problems: > > 1) One of the commit messages needs to be fixed > Two were kept for history, I removed them from the branch. NOT OK - QA script still complains: * Commit title does not contain 'follow-up' correctly spelt - fd8d8f5ba2 (Bug 33568: (folow-up) Restore filters) * We also got some perltidy complaints on top. > > 2) When there is no barcode, it appears as 'null' in the column > Fixed in "Bug 33568: Do not display 'null' when no barcode" OK - Confirmed fixed. > > 3) 'Host records' column should not be available, when EasyAnalytics is > > turned off. > > Fixed in "Bug 33568: Hide 'Host records' if EasyAnalyticalRecords is off" OK - Confirmed fixed. > > 4) Table configuration doesn't appear to be used as expected. I checked: > > Catalog > holdings_table has only holdings_issues and holdings_renewals > > hidden by default. But the table keeps appearing with only a minimum number > > of columns and a lot of them hidden. Unfortunately the hidden column also > > includes much neded ones like callnumber. Any changes I make don't seem to > > stick. > > The table is hiding empty columns. So if the x items displayed on the page > do not have callnumber, then the column will be hidden, even if other pages > have items with callnumber. Is that what you are seeing? > See commit message "Bug 33568: Hide empty columns". > It is what we are doing already on master, but here we don't want to fetch > all the items to know if data exist for each each column... DISCUSS - Yes, confirmed - the column visibility is determined by the value savailable on the first visible page. I think this could be problematic, I'd really like to get more opinions, favourably from daily Koha users on this. > > 5) SpineLabelShowPrintOnBibDetails: the callnumber print on longer opens in > > small size modal. This also has the effect, that there is no way to close > > this window without printing. > > Fixed in "Bug 33568: Fix popup behaviour for SpineLabelShowPrintOnBibDetails" NOT OK - I yarn build, restart_all... but the modal is not 'modaling' for me. I still opens full size in a new tab. > > 6) The status column is no longer sortable. It's sortable in 22.11 and works > > well there. Alos: I can't activate a filter for this column and the normal > > filter doesn't find the contents of the column. There is no way to find the > > 'checked out' or 'ordered' items in that list. > > See commit message for "Bug 33568: Status" > """ > See the FIXME in the code, we are losing the ability to search on the > status, > but this is really impossible to implement if we are not storing the > status (DB or search engine). > """ DISCUSS - So the problem here is that we are storing different numeric values and therefore cannot sort on anything useful... is that it? I believe that could be an issue for a lot of libraries, as it stands now for the before and after: Before * Can sort on status * Can search on status using column filter * Can search on status using the top table search field (overall search) After * Can't do any of that. It's definitely something that we need to get more eyes on again as it could be seen as quite disruptive. Crazy idea: could we collect the status appearing in the data (all of them) and provide a pull down for limiting somehow? A multi select maybe? > > 7) When an item is checked out, there is no longer a link to the patron's > > account. > > Fixed in "Bug 33568: Restore link to patron" OK - Confirmed fixed. > > 8) hidepatronname doesn't seem to have any effect. > > I think this is a bug in js-patron-format.inc, it should be reported > separately. I double-checked in current master: hide: Checked out to 42 : due 04.11.2023 don't hide: Checked out to koha (42) : due 04.11.2023 So it does look like it's related to this patch set somehow. Sorry. > > 9) Using the single search box on top of the table: "checked" doesn't find > > the checked out items. In 22.11 that works. > > If we want that we need a filter at the top of the page. That should be a > separate bug. I was talking about the filter on top of the table - are we talking about the same thing? > > 10) StaffDetailItemSelection: when disabled, not only the checkboxes are > > gone, but I can also no longer activate the column specific filters. In > > 22.11 this is still possible when the select feature is disabled. > > Fixed in "Bug 33568: Restore column filters when StaffDetailItemSelection is > off" OK - Confirmed fixed. 11) NEW: Column filters for item type and current library don't show as a pull down. Holding branch does. > > Notes/Questions: > > 1) Currently some column only show when there is data for them, like course > > reserves. this is very helpful in preserving space, but doesn't seem to be > > the case anymore. > > "Preserving space"? > See above. Yep, understood now. Hesitating. > > 2) Right now we see all items immediately in the table, one the page has > > loaded. Now we only see the first 20. Libraries might feel this is a too low > > default setting. It would be great if we could have that configurable in > > table settings from the start. > > It should be very easy to implement. I will do it when this reaches master. I filed it separately as: Bug 35191 - Make entries per page configurable for items table on staff detail page -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
