https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157
--- Comment #35 from Marcel de Rooy <[email protected]> --- QA Comment: Squashed first 3 patches: Resolving: FAIL git manipulation The file has been added and deleted in the same patchset. Tidied a bit more. Follow-up: Renamed some vars. Removed unused $success. Extended die statement. Added Modern::Perl. FIXED Serious omission: $confirm DOES NOT DO anything ! Blocker TODO The expiration parameter is not tested in any way? Does not feel good. (No definitive blocker for me.) TODO If we added a debarment and run the script again, we will add another debarment. Please add a check. (Doubt if this is a blocker.) TODO We need a manual option like other scripts? No blocker for me. DONE We need a verbose parameter as Lucas mentioned. DONE If we do not confirm, I would expect to list patron info in verbose mode. DONE I would add a count at the end. May be no blocker, but generally expected. Please still add a follow-up or leave final decision to RM. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
