https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
--- Comment #180 from Katrin Fischer <[email protected]> --- I can see we had a lot of iterations here already. I did some testing to help out, but I think I'll leave it to Marcel to finish: 1) QA test tools We have a fail for TT filters: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc FAIL filters wrong_html_filter at line 90 ( <a href="/cgi-bin/koha/opac-export.pl?format=[% filesOption.format | html %]&op=exportxsl&file=[% filesOption.value | html %]&bib=[% biblionumber | html %]" >XSL - [% filesOption.filename | html %]</a>) wrong_html_filter at line 90 ( <a href="/cgi-bin/koha/opac-export.pl?format=[% filesOption.format | html %]&op=exportxsl&file=[% filesOption.value | html %]&bib=[% biblionumber | html %]" >XSL - [% filesOption.filename | html %]</a>) wrong_html_filter at line 90 ( <a href="/cgi-bin/koha/opac-export.pl?format=[% filesOption.format | html %]&op=exportxsl&file=[% filesOption.value | html %]&bib=[% biblionumber | html %]" >XSL - [% filesOption.filename | html %]</a>) ... and a lot of perltidy warns. 2) Export format pull down + <li><a href="/cgi-bin/koha/catalogue/export.pl?format=[% filesOption.format | uri %]&op=exportxsl&file=[% filesOption.value | uri %]&bib=[% biblionumber | uri %]">XSL - [% filesOption.filename | html %]</a></li> and other occurences. As we are not exporting an XSL file, it would be nice to rephrase this. Maybe we should just remove XSL in favor of just having the file name? 3) Export format description In the system preference we have: + custom: XSL - Simple Export * Capitalization * We don't export XSL, I believe something like: Simple HTML format would probably be a better match? * It would also guide any other added custom export format, if I understand correctly, so maybe even: Custom export formats, including simple HTML? + $format = "html" if ($format =~ /^xsl\./); It looks like we always assume it will be an HTML file? 4) Commit messages include no test plan. 5) New option for system preference I think we need a database update adding the option to OpacExportOptions and also update sysprefs.sql. 6) I am struggling with adding the sample files to Koha. They are great for testing this, but I am not sure if they are helpful as they are. At the moment, they are incomplete/invalid HTML files. <p xmlns:marc="http://www.loc.gov/MARC21/slim";>Programming Perl / Tom Christiansen, Brian D. Foy & Larry Wall.<br>Beijing ; O'Reilly, c2012.</p> 7) The path for the custom formats is not configurable. I guess any files added there by libraries could be potentially be overwritten in updates. If this is for custom formats, maybe we should allow for a custom path as well. Overall the concept here feels a little rough. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
