https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #98 from Katrin Fischer <[email protected]> --- 1) This one feels a little strange as it includes the advanced MARC editor and the old svc/HTTP API, but not the rest API. I can't test that API so I don't feel comfortable to pass QA here and would like to hand over to someone who can. 2) Are they really both needed? +use C4::MarcModificationTemplates; +use Koha::MarcModificationTemplates; 3) QA test tools I got them mostly to pass with my follow-ups, but _please_ don't rely on the QA team for those fixes, usually there is no time for such things. This seems a false positive, the file is new and I perltidied it, but this remains: WARN t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) 4) Deleting the template breaks editors * Advanced editor no longer let's you save a record with an unspecific error message Logs: Carp::croak('No MARC modification template exists with id "13"') called at /kohadevbox/koha/svc/bib line 137 * Normal editor explodes into an error: No MARC modification template exists with id "13" at /usr/share/perl5/CGI/Compile.pm line 151. at /usr/lib/x86_64-linux-gnu/perl-base/Carp.pm line 289 I feel we need to handle this more gracefully. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
