https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27992 Status|Signed Off |Failed QA --- Comment #56 from Katrin Fischer <[email protected]> --- **ATTENTION** We might want to push the bugfix from bug 27992 first, although it might create a small conflict in Circulation.pm here. 1) QA test script Still applies, but requires perltidy: WARN C4/Circulation.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 1104, now: 1108) WARN installer/data/mysql/atomicupdate/bug_16122_atomicupdate.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 10) WARN misc/maintenance/update_localuse_from_statistics.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 8) Fixed in a follow-up. Also fixed: * COMMENT in database update and kohastructure didn't match up * some spelling 2) We need unit tests. (blocker) 3) Column configuration page for items table on detail page needs to be updated. Suggestion: I'd hide this column by default for existing and new installations to not grow the items table. 4) Maintenance script +use strict; +use warnings; Should be: use Modern::Perl; It feels like this should have a verbose option and maybe a warning/hint that existing entries in items will be overwritten? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
